RFR: 8285485: Fix typos in corelibs
Pavel Rappo
prappo at openjdk.java.net
Wed Apr 27 17:39:45 UTC 2022
On Fri, 22 Apr 2022 15:08:51 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
> I ran `codespell` on modules owned by core-libs, and accepted those changes where it indeed discovered real typos.
>
> I will update copyright years using a script before pushing (otherwise like every second change would be a copyright update, making reviewing much harder).
>
> The long term goal here is to make tooling support for running `codespell`. The trouble with automating this is of course all false positives. But before even trying to solve that issue, all true positives must be fixed. Hence this PR.
Thanks for doing this so carefully. If reviewers decide that parts of this PR need to be addressed upstream, we should probably consider contributing those parts to respective projects.
src/java.sql.rowset/share/classes/com/sun/rowset/CachedRowSetImpl.java line 970:
> 968: * and sends a <code>rowSetChanged</code> event to all registered
> 969: * listeners.
> 970: * @throws SQLException if an error is occurs rolling back the RowSet
L976, same as above: "is occurs".
src/java.sql.rowset/share/classes/com/sun/rowset/JoinRowSetImpl.java line 636:
> 634: // to be INNER JOIN'ED to form a new rowset
> 635: // Compare table1.MatchColumn1.value1 == { table2.MatchColumn2.value1
> 636: // ... up to table2.MatchColumn2.valueN }
Curious: it is not some established string representation, is it?
src/java.sql.rowset/share/classes/com/sun/rowset/internal/SyncResolverImpl.java line 664:
> 662: * and sends a {@code rowSetChanged} event to all registered
> 663: * listeners.
> 664: * @throws SQLException if an error is occurs rolling back the RowSet
L664: delete "is" in "is occurs".
src/java.sql.rowset/share/classes/com/sun/rowset/providers/RIXMLProvider.java line 239:
> 237:
> 238: /**
> 239: * Returns the vendor name of the Reference Implementation Optimistic
L240: an optimistic _what_ provider? :-)
src/java.xml/share/classes/com/sun/xml/internal/stream/writers/XMLDOMWriterImpl.java line 238:
> 236:
> 237: /**
> 238: * Creates a DOM Attribute @see org.w3c.dom.Node and associates it with the current DOM element @see org.w3c.dom.Node.
Not that it matters in this PR, but I think I should mention that `@see` tags do not work like that. (No action needed from you.)
src/java.xml/share/classes/javax/xml/transform/Transformer.java line 127:
> 125: * namespace URI in curly braces ({}).
> 126: * @param value The value object. This can be any valid Java object. It is
> 127: * up to the processor to provide the proper object coersion or to simply
That made me pause: some systems have the notion of _type coercion_; but your change looks right.
-------------
PR: https://git.openjdk.java.net/jdk/pull/8364
More information about the nio-dev
mailing list