RFR: 8274112: (fc) Tune FileChannel.transferTo() [v6]

Brian Burkhalter bpb at openjdk.java.net
Fri Apr 29 23:05:46 UTC 2022


On Fri, 29 Apr 2022 16:37:06 GMT, Lance Andersen <lancea at openjdk.org> wrote:

>> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8274112: Revert all changes except mapped transfer threshold
>
> test/jdk/java/nio/channels/FileChannel/TransferToChannel.java line 52:
> 
>> 50:     private static final Random RAND = RandomFactory.getRandom();
>> 51: 
>> 52:     private static final int FILE_SIZE = 1000*1024;
> 
> Could use a comment regarding the reason the file size is what it is

I don't recall why that particular value was chosen except in relation to other constants. Will add some comments.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5623


More information about the nio-dev mailing list