RFR: 8290047: (fs) FileSystem.getPathMatcher does not check for ":" at last index [v4]

Brian Burkhalter bpb at openjdk.org
Tue Aug 2 16:18:16 UTC 2022


> For a `String` “s”, `s.indexOf(int)` can never return a value `>= s.length()` so change the check
> 
>         int pos = syntaxAndInput.indexOf(':');
>         if (pos <= 0 || pos == syntaxAndInput.length())
> 
> to
> 
>         if (pos <= 0)

Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:

  8290047: Remove check for ':' at last position

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/9595/files
  - new: https://git.openjdk.org/jdk/pull/9595/files/ff404d4b..1af2a4b4

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=9595&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=9595&range=02-03

  Stats: 26 lines in 6 files changed: 6 ins; 12 del; 8 mod
  Patch: https://git.openjdk.org/jdk/pull/9595.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/9595/head:pull/9595

PR: https://git.openjdk.org/jdk/pull/9595


More information about the nio-dev mailing list