RFR: 8264744: (fs) Use file cloning in Linux and macOS versions of FileChannel transfer and Files copy methods [v6]

[Alan Bateman]

On Wed, 10 Aug 2022 01:05:06 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> Add file cloning to `java.nio.channels.FileChannel::transferTo` and `java.nio.file.Files.copy(Path,Path)`.
>
> Brian Burkhalter has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:
> 
>  - 8264744: Remove CloneFile classes; refactor to use {Bsd,Linux}CopyFile
>  - Merge
>  - 8264744: Fix typo desintation -> destination
>  - 8264744: Refactor into UnixCopyFile hierarchy
>  - Merge
>  - 8264744: Address review comments aside from refactoring
>  - 8264744: Refactor into provider+dispatcher to reduce amount of JNI code
>  - 8264744: (fc, fs) Support file cloning in Unix versions of FileChannel transfer and Files copy methods

Thanks for the update. One thing that I should have pointed out in previous comments is UnixFileSystem.copyNonPosixAttributes. This is overridden in LinuxFileSystem and others and I think gives you an example of how to add the clone method without needing fileCopier. Would you be able to try that? I suspect the patch will reduce if that is used as the template.

-------------

PR: https://git.openjdk.org/jdk/pull/9486