RFR: 8292562: (fc) Use copy_file_range in FileChannel::transferTo on Linux [v4]
Alan Bateman
alanb at openjdk.org
Tue Aug 23 10:55:21 UTC 2022
On Mon, 22 Aug 2022 18:20:40 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:
>> Add `copy_file_range(2)` to the native Linux implementation of `FileChannel::transferTo`.
>
> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>
> 8292562: Add test of transferTo while target is appending
Marked as reviewed by alanb (Reviewer).
Aside from the check if copy_file_range is supported then I think the change to the transferTo implementation in c3c36f1d looks good. At some point I would expect we will pass the append flag from the java code. Have you looked at transferFrom for the append case? I suspect it is masked by the check for EBADF and now may be the time to re-examine that (okay to be a separate PR but hopefully you see the issue there).
-------------
PR: https://git.openjdk.org/jdk/pull/9925
More information about the nio-dev
mailing list