RFR: 8298187: (fs) BsdFileAttributeViews::setTimes does not support lastAccessTime on HFS+ [v4]

[Brian Burkhalter]

On Tue, 13 Dec 2022 10:10:59 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8298187: Fix a comment
>
> src/java.base/macosx/classes/sun/nio/fs/BsdFileAttributeViews.java line 57:
> 
>> 55:                 fd = path.openForAttributeAccess(followLinks);
>> 56:             } catch (UnixException x) {
>> 57:                 x.rethrowAsIOException(path);
> 
> The try-open-catch shouldn't be nested in the other try-catch. If the open fails there is no fd to close and no suppressed exception to add.

Corrected in d9606e74d1869c3f548a6b7c6bef12b2c1e005ac.

> src/java.base/macosx/classes/sun/nio/fs/BsdNativeDispatcher.java line 98:
> 
>> 96:         } finally {
>> 97:             Blocker.end(comp);
>> 98:             }
> 
> Can you check the formatting here, the end brace seems to be in pushed out.

Corrected in d9606e74d1869c3f548a6b7c6bef12b2c1e005ac.

-------------

PR: https://git.openjdk.org/jdk/pull/11600