RFR: 8298187: (fs) BsdFileAttributeViews::setTimes does not support lastAccessTime on HFS+ [v6]

Alan Bateman alanb at openjdk.org
Thu Dec 15 14:46:11 UTC 2022


On Wed, 14 Dec 2022 18:25:00 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> If the path is on an HFS store, use the generic Unix implementation of `java.nio.file.attribute.BasicFileAttributeView::setTimes`to set the last access time.
>
> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8298187: Fix symbolic link case when links not followed

Marked as reviewed by alanb (Reviewer).

src/java.base/macosx/classes/sun/nio/fs/BsdFileAttributeViews.java line 100:

> 98:                         futimens(fd, accessValue, modValue);
> 99:                 } catch (UnixException x) {
> 100:                     // if futimens fails with EINVAL and one/both of the times is

The comment should probably say "lutimes/futimens".

-------------

PR: https://git.openjdk.org/jdk/pull/11600


More information about the nio-dev mailing list