RFR: 8278268 - (ch) InputStream returned by Channels.newInputStream should have fast path for FileChannel targets [v8]

[Markus KARG]

On Sun, 2 Jan 2022 21:56:59 GMT, Lance Andersen <lancea at openjdk.org> wrote:

>>> @LanceAndersen I assumed the second test will exist only for the time until we fixed the Windows problems, so I did not invest time to reduce duplication so far. So you really want to keep the separated tests forever and want me to reduce duplication?
>> 
>> I would not make any such assumptions especially for tests that create large files.  So yes please address the duplication.  It is not a huge amount of work to  create a base class that the tests extend (you will see examples elsewhere within the various test directories).
>
>> @LanceAndersen I'm done with the requested changes. For "the remaining tests" I kept the separation into TransferTo (existing tests) and TransferTo2 (new tests of this PR) -- or do you want me to consolidate TransferTo2 into TransferTo now that Alan identified the source of trouble being the Unix Domain Sockets?
> 
> I haven't gone through this in detail, but we want to merge The remaining TransferTo2 tests into TransferTo.  For the  large File tests, any duplicate code can also be included in the base class.
> 
> I will look at this more when I am back from the holiday break

@LanceAndersen "Ping" :-)

-------------

PR: https://git.openjdk.org/jdk/pull/6711