RFR: 5041655: (ch) FileLock: negative param and overflow issues [v9]

Brian Burkhalter bpb at openjdk.java.net
Fri Feb 11 18:33:56 UTC 2022


> Add an implementation note to `java.nio.channels.FileLock.overlaps(long,long)` indicating that the method does not check its parameters. Adding such checks would be an incompatible change.

Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:

  5041655: Modify existing tests to verify that creating a lock with size zero yields size Long.MAX_VALUE - position

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/7254/files
  - new: https://git.openjdk.java.net/jdk/pull/7254/files/d56daa9b..537525ea

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7254&range=08
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7254&range=07-08

  Stats: 68 lines in 2 files changed: 49 ins; 3 del; 16 mod
  Patch: https://git.openjdk.java.net/jdk/pull/7254.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/7254/head:pull/7254

PR: https://git.openjdk.java.net/jdk/pull/7254


More information about the nio-dev mailing list