RFR: 8280944: Enable Unix domain sockets in Windows Selector notification mechanism [v3]

Daniel Fuchs dfuchs at openjdk.java.net
Wed Feb 23 10:14:53 UTC 2022


On Tue, 22 Feb 2022 22:41:10 GMT, ExE Boss <duke at openjdk.java.net> wrote:

>> Michael McMahon has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   second review comments
>
> src/java.base/windows/classes/sun/nio/ch/PipeImpl.java line 182:
> 
>> 180:      */
>> 181:     PipeImpl(SelectorProvider sp) throws IOException {
>> 182:         this(sp, true, false);
> 
> I’m pretty sure that this should actually be:
> Suggestion:
> 
>         this(sp, /*AF_UNIX*/ false, /*buffering*/ true);

Good catch. I will log a bug for that. In practice (and fortunately) it doesn't really matter since AFAICT this constructor is never called.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7302


More information about the nio-dev mailing list