RFR: 8280944: Enable Unix domain sockets in Windows Selector notification mechanism [v3]

[Michael McMahon]

On Wed, 2 Feb 2022 12:12:36 GMT, Michael McMahon <michaelm at openjdk.org> wrote:

>> Hi,
>> 
>> Could I get the following change reviewed please?
>> 
>> 8280233 temporarily disabled AF_UNIX sockets in the windows pipe implementation due to a Windows bug. We would like to re-enable one internal usage of AF_UNIX pipes in the JDK, for the windows NIO selector notification mechanism since this use case does not involve closing the socket and should therefore not encounter the bug.
>> 
>> I haven't included a regression test as this change will exercise tests that are currently running into TCP resource limitations on windows 10 client systems.
>> 
>> Thanks,
>> Michael
>
> Michael McMahon has updated the pull request incrementally with one additional commit since the last revision:
> 
>   second review comments

Right. The mistake is in the comment. It should say:

"Creates an unbuffered Pipe implementation" rather than 

"Creates a Pipe implementation that supports buffering"

I can fix that easily. Changing the default constructor to create a buffered socket would not work with AF_UNIX sockets as they don't have an equivalent to TCP_NODELAY

-------------

PR: https://git.openjdk.java.net/jdk/pull/7302