RFR: 8280881: (fs) UnixNativeDispatcher.close0 may throw UnixException [v6]

Alan Bateman alanb at openjdk.java.net
Sun Feb 27 18:22:52 UTC 2022


On Fri, 25 Feb 2022 21:26:37 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> Re-specify `sun.nio.fs.UnixNativeDispatcher.close0()` to throw `sun.nio.fs.UnixException` and modify callers either to ignore it or to rethrow it as an `IOException`, as appropriate.
>
> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8280881: Suppress some more exceptions; remove no longer needed close()

This version is looking much better, just one issue in UnixCopyFile, the rest looks good.

src/java.base/unix/classes/sun/nio/fs/UnixCopyFile.java line 189:

> 187:                 if (sfd >= 0) {
> 188:                     source.getFileSystem().copyNonPosixAttributes(sfd, dfd);
> 189:                     close(sfd, null);

This should be `close(sfd, e -> null);`

-------------

PR: https://git.openjdk.java.net/jdk/pull/7467


More information about the nio-dev mailing list