[jdk18] RFR: 8280233: disable Unix domain sockets in PipeImpl [v2]
Michael McMahon
michaelm at openjdk.java.net
Wed Jan 19 13:25:03 UTC 2022
> Hi,
>
> Could I get the following change reviewed please? Pending full investigation of the cause of (JDK-8278369) we want to disable the use of Unix domain sockets in the Windows Pipe implementation, reverting to the previous (pre JDK 16) TCP socket impl. The TCP impl was always used in versions of windows other than 10, 2019 server+ that didn't support Unix domain sockets. There isn't a regression test as existing Pipe tests should be sufficient.
>
> It's not clear at this point if the issue is a JDK or Windows bug but it's expected the Unix domain impl will be restored later. UNIX protocol family SocketChannel/ServerSocketChannels still work after this change.
>
> Thanks,
>
> Michael.
Michael McMahon has updated the pull request incrementally with one additional commit since the last revision:
removed dead code that handles UnixDomainSocketAddress
-------------
Changes:
- all: https://git.openjdk.java.net/jdk18/pull/109/files
- new: https://git.openjdk.java.net/jdk18/pull/109/files/5079d373..19f3a5c4
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk18&pr=109&range=01
- incr: https://webrevs.openjdk.java.net/?repo=jdk18&pr=109&range=00-01
Stats: 5 lines in 1 file changed: 0 ins; 5 del; 0 mod
Patch: https://git.openjdk.java.net/jdk18/pull/109.diff
Fetch: git fetch https://git.openjdk.java.net/jdk18 pull/109/head:pull/109
PR: https://git.openjdk.java.net/jdk18/pull/109
More information about the nio-dev
mailing list