RFR: 8279946: (ch) java.nio.channels.FileChannel tryLock and write methods are missing @throws NonWritableChannelException [v2]

Lance Andersen lancea at openjdk.java.net
Thu Jan 20 18:09:49 UTC 2022


On Thu, 20 Jan 2022 17:59:25 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> Please consider this change which would add `@throws` clauses for `NonWritableChannelException` to the various `tryLock()` and `write()` methods in `java.nio.channels.FileChannel`.
>
> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8279946: Add missing NonReadableChannelException for tryLock(long,long,boolean)

This looks better Brian.  Thank you for the update.

Given FileChannel::tryLock() calls the method you updated, shouldn't we also update its javadoc for the relevant exceptions?

-------------

PR: https://git.openjdk.java.net/jdk/pull/7058


More information about the nio-dev mailing list