RFR: 8057113: (fs) Path should have a method to obtain the filename extension [v9]
Brian Burkhalter
bpb at openjdk.org
Tue Jul 5 16:53:16 UTC 2022
On Fri, 6 May 2022 10:38:30 GMT, Lance Andersen <lancea at openjdk.org> wrote:
>> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>>
>> 8057113: Remove superfluous new Object[] statements from test
>
> test/jdk/java/nio/file/Path/Extensions.java line 38:
>
>> 36: * @run testng Extensions
>> 37: */
>> 38: public class Extensions {
>
> Can you add a test to exercise the change you made to ZipFS->ZipPath
That code has been reverted.
> test/jdk/java/nio/file/Path/Extensions.java line 95:
>
>> 93: {"video.mp4", of("mp4")},
>> 94: {"document.txt", of("txt")},
>> 95: };
>
> Should we add a x.zip, y.gzip, and z.jar given they are common?
Done in ec417a8938a6e50a473c2f3c9242f9a897f189b6.
-------------
PR: https://git.openjdk.org/jdk/pull/8066
More information about the nio-dev
mailing list