RFR: 8287602: (fs) Avoid redundant HashMap.containsKey call in MimeTypesFileTypeDetector.putIfAbsent

Jaikiran Pai jpai at openjdk.java.net
Wed Jun 1 04:00:32 UTC 2022


On Sun, 29 May 2022 20:41:04 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

> Only non-null values are put into `Map<String,String> mimeTypeMap`. It means, we can replace `containsKey`+`put` calls with single `putIfAbsent` call. It makes code a bit cleaner and faster.
> 
> https://github.com/openjdk/jdk/blob/3d2d039538b906cedd9188ed94b7ba55c275ff7f/src/java.base/unix/classes/sun/nio/fs/MimeTypesFileTypeDetector.java#L189-L196

Marked as reviewed by jpai (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/8941


More information about the nio-dev mailing list