RFR: 8287809: Revisit implementation of memory session [v2]
Jorn Vernee
jvernee at openjdk.java.net
Wed Jun 15 14:58:25 UTC 2022
On Wed, 15 Jun 2022 14:41:17 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:
>> Maurizio Cimadamore has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 14 commits:
>>
>> - Merge branch 'master' into cleanup_memory_session_impl_state
>> - Add null check on Buffer::checkState
>> - Add docs
>> Simplify liveness check in Buffer
>> Drop redundant import in DirectBuffer
>> - Simplify checkValidState
>> - Add fastpath for implicit session state
>> - Merge branch 'master' into cleanup_memory_session_impl_keep_list
>> - Fix asNonCloseable to return self
>> Improve direct buffer code with isImplicit predicate
>> - Drop MemorySession interface type from AbstractMemorySessionImpl
>> - Simplify code by removing intermediate getUnsafeBase/getUnsafeOffset methods
>> - Simplify readOnly check
>> - ... and 4 more: https://git.openjdk.org/jdk/compare/8d28734e...5b8f7246
>
> src/java.base/share/classes/jdk/internal/foreign/ConfinedSessionState.java line 40:
>
>> 38: * operations triggered by threads other than the owner thread, which we support.
>> 39: */
>> 40: public final class ConfinedSessionState extends MemorySessionImpl.State {
>
> Same here. I don't see why this is made public now.
Same for `justClose` and `ConfinedList::add` in this file. They still seem only accessed in the same package.
-------------
PR: https://git.openjdk.org/jdk/pull/9017
More information about the nio-dev
mailing list