RFR: 6980847: (fs) Files.copy needs to be tuned [v7]

Alan Bateman alanb at openjdk.org
Wed Jun 22 06:49:38 UTC 2022


On Wed, 22 Jun 2022 01:15:19 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> Modify `UnixCopyFile.copyFile()` to set the transfer size to the least common multiple of the source and destination file block sizes if the block sizes are not equal. Modify `WindowsFileCopy.copy()` to set `COPY_FILE_NO_BUFFERING` in the flags passed to `CopyFileEx()` if the size of the transfer is greater than a threshold.
>
> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
> 
>   6980847: Cleanup

src/java.base/windows/classes/sun/nio/fs/WindowsFileCopy.java line 182:

> 180:             long size = 0;
> 181:             try {
> 182:                 size = Files.size(source);

Are you going to change this to use sourceAttrs.size() ?

-------------

PR: https://git.openjdk.org/jdk/pull/9161


More information about the nio-dev mailing list