RFR: 6980847: (fs) Files.copy needs to be tuned [v9]

[Brian Burkhalter]

On Wed, 22 Jun 2022 16:51:46 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> src/java.base/windows/classes/sun/nio/fs/WindowsFileCopy.java line 188:
>> 
>>> 186:             final int flags = ((!followLinks) ? COPY_FILE_COPY_SYMLINK : 0) |
>>> 187:                               ((sourceAttrs.size() > UNBUFFERED_IO_THRESHOLD) ?
>>> 188:                                   COPY_FILE_NO_BUFFERING : 0);
>> 
>> Would this be easier to read:
>> 
>> 
>>         int flags = (followLinks) ? 0 : COPY_FILE_COPY_SYMLINK;
>>         if (sourceAttrs.size() > UNBUFFERED_IO_THRESHOLD) {
>>             flags |= COPY_FILE_NO_BUFFERING;
>>         }
>
> I did not do that because `flags` is final but I guess it need not be.

Actually `flags` must be final as it is referenced from an inner class.

-------------

PR: https://git.openjdk.org/jdk/pull/9161