RFR: 8267820: (fs) Files.copy should attempt to copy POSIX attributes when target file in custom file system [v2]

Alan Bateman alanb at openjdk.java.net
Wed Mar 9 08:40:07 UTC 2022


On Tue, 8 Mar 2022 20:22:48 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> In `java.nio.file.Files.copy()` copy POSIX attributes even if the target is from a different file system provided both the source and target file systems support such attributes.
>
> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8267820: Set permissions only, not owner nor group

The change to CopyMoveHelper look okay. If you are doing another round of cleanup then one thing that could be improve is the naming. The parameters "source" and "target" but the variables switch to "src" and "dst" so a bit inconsistent.

-------------

Marked as reviewed by alanb (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7627


More information about the nio-dev mailing list