RFR: 8279339: (ch) Input/Output streams returned by Channels factory methods don't support concurrent read/write ops [v2]

Markus KARG duke at openjdk.java.net
Sun Mar 20 16:54:34 UTC 2022


On Wed, 5 Jan 2022 18:18:24 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> This looks good.  Thank you for addressing.
>> 
>> I typically use assertThrows vs expectThrows for consistency with the other assertXXX
>
>> I typically use assertThrows vs expectThrows for consistency with the other assertXXX
> 
> I've got into the habit of using expectThrows because tests will often need to check the exception cause (assertThrows is void). I don't mind changing it as either will work for this test.

Thanks a lot @AlanBateman for fixing this longstanding issue. I am pretty sure, @trishagee is not the only one really appreciating this fix! ����

-------------

PR: https://git.openjdk.java.net/jdk/pull/6953


More information about the nio-dev mailing list