RFR: 8283756: (zipfs) ZipFSOutputStreamTest.testOutputStream should only check inflated bytes [v3]

Lance Andersen lancea at openjdk.java.net
Mon Mar 28 10:14:53 UTC 2022


On Mon, 28 Mar 2022 10:13:15 GMT, Volker Simonis <simonis at openjdk.org> wrote:

>> The test `ZipFSOutputStreamTest` deflates content into a zip file system and subsequently inflates the deflated files and checks their content against the original data.
>> 
>> The content consists of a data stream of bytes with the value `42`.
>> 
>> The check currently compares the temporary inflation buffer with the original source buffer, no matter how many bytes were inflated into the inflation buffer. This can lead to problems with alternative zlib implementations which sometimes write beyond the last inflated byte (see [JDK-8282648](https://bugs.openjdk.java.net/browse/JDK-8282648) for more details).
>> 
>> The fix is trivial. Only compare as many bytes as have been inflated against the original content.
>
> Volker Simonis has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   8283756: (zipfs) ZipFSOutputStreamTest.testOutputStream should only check inflated bytes

Marked as reviewed by lancea (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/7984


More information about the nio-dev mailing list