RFR: 8285956: (fs) Excessive default poll interval in PollingWatchService [v3]
Brian Burkhalter
bpb at openjdk.java.net
Mon May 2 21:07:32 UTC 2022
On Mon, 2 May 2022 20:56:04 GMT, Tyler Steele <duke at openjdk.java.net> wrote:
>> PollingWatchService.java contains the WatchService and WatchKey implementation for AIX and BSD. When a Path is [register](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/nio/file/Path.html#register(java.nio.file.WatchService,java.nio.file.WatchEvent.Kind...))ed this implementation creates a polling thread to monitor for file system changes. Currently, this thread waits 10 seconds before it's first poll, and then waits 10 seconds between subsequent polls. This interval leads to sluggish performance.
>>
>> This PR makes the following changes:
>> - Sets the initial interval to 1 second regardless of the period.
>> - Change the default period to 1 second.
>>
>> All tests in `test/jdk/java/nio/file/WatchService` passing.
>
> Tyler Steele has updated the pull request incrementally with one additional commit since the last revision:
>
> Adds suggested changes to comment
src/java.base/share/classes/sun/nio/fs/PollingWatchService.java line 313:
> 311: this.events = events;
> 312:
> 313: // create the periodic task with initialDelay set to the default sensitivity
I don't think "default sensitivity" is apt any more; perhaps "specified constant" instead?
```// create the periodic task with initialDelay set to the specified constant```
-------------
PR: https://git.openjdk.java.net/jdk/pull/8479
More information about the nio-dev
mailing list