RFR: 8057113: (fs) Path should have a method to obtain the filename extension [v9]
Lance Andersen
lancea at openjdk.java.net
Fri May 6 10:43:48 UTC 2022
On Wed, 4 May 2022 21:07:14 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:
>> Resurrection of the proposal to add a method to obtain the filename extension originated in PR [2319](https://github.com/openjdk/jdk/pull/2319).
>
> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>
> 8057113: Remove superfluous new Object[] statements from test
Hi Brian,
Looking good overall. Please see the comments below regarding the test
test/jdk/java/nio/file/Path/Extensions.java line 38:
> 36: * @run testng Extensions
> 37: */
> 38: public class Extensions {
Can you add a test to exercise the change you made to ZipFS->ZipPath
test/jdk/java/nio/file/Path/Extensions.java line 95:
> 93: {"video.mp4", of("mp4")},
> 94: {"document.txt", of("txt")},
> 95: };
Should we add a x.zip, y.gzip, and z.jar given they are common?
-------------
PR: https://git.openjdk.java.net/jdk/pull/8066
More information about the nio-dev
mailing list