RFR: 8286689: (se) Adjusting to select timeout after EINTR messed up after JDK-8286378

Jaikiran Pai jpai at openjdk.java.net
Fri May 13 08:38:41 UTC 2022


On Fri, 13 May 2022 08:13:35 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review which fixes a recent unintentional change that went in as part of https://github.com/openjdk/jdk/pull/8642? The issue was caught here https://github.com/openjdk/jdk/pull/8642/files#r871994710 after the change was integrated.

Hello Alan,

>  can we update KQueueSelectImpl.doSelect too, this was missed by JDK-8286378, I assume because the test with the new compiler option was only done on one platform.

In the case of `KQueueSelectorImpl.doSelect()`, the `to` is already a `long`, unlike in these 2 classes where it's an `int`. The `to` then gets passed to `KQueue.poll(...)` which expects a `long` timeout unlike in the above 2 classes where the `to` gets passed to methods which expect an `int` timeout. I believe that was the reason the compiler didn't complain in case of `KQueueSelectorImpl`.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8693


More information about the nio-dev mailing list