RFR: 8286689: (se) Adjusting to select timeout after EINTR messed up after JDK-8286378

Jaikiran Pai jpai at openjdk.java.net
Fri May 13 08:51:35 UTC 2022


On Fri, 13 May 2022 08:39:48 GMT, Alan Bateman <alanb at openjdk.org> wrote:

> However, part of my comment is that there is an inconsistency because KQueueSelectImpl.doSelect wasn't changed to use toMillis. 

You are right. I was focusing too much on the casting and the LHS, that I didn't notice this API usage. I have now updated the PR to use `toMillis`. I ran a local build on my macOS to make sure this doesn't break anything obvious. Build went fine.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8693


More information about the nio-dev mailing list