RFR: 8286671: (fc) Modify sun.nio.ch.FileChannelImpl.map0() to accept a FileDescriptor parameter [v2]

Brian Burkhalter bpb at openjdk.java.net
Fri May 13 15:45:38 UTC 2022


On Fri, 13 May 2022 14:45:35 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> src/java.base/unix/native/libnio/ch/FileChannelImpl.c line 54:
>> 
>>> 52: 
>>> 53: JNIEXPORT jlong JNICALL
>>> 54: Java_sun_nio_ch_FileChannelImpl_initIDs(JNIEnv *env, jclass clazz)
>> 
>> Hello Brian, now that this function doesn't initialize ids, should it instead be renamed to something else? Also the corresponding `initIDs` method on the Java side? And perhaps remove this comment from `FileChannelImpl.java`:
>> 
>> 
>>     // Caches fieldIDs
>>     private static native long initIDs();
>
> Yeah I had thought of that as well but shined it on. I'll update before integrating.

Resolved by 0c707e41492a682967f522ce03894f87a133a16f.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8689


More information about the nio-dev mailing list