RFR: 8286637: (fc) Memory mapped regions bigger than 2GB do not work correctly on Windows [v4]
Alan Bateman
alanb at openjdk.java.net
Mon May 16 18:45:36 UTC 2022
On Mon, 16 May 2022 18:21:20 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:
>> Cast the last parameter `dwNumberOfBytesToMap` of `MapViewOfFile()` to a `SIZE_T`, not a `DWORD`, to avoid truncation.
>
> Brian Burkhalter has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
>
> 8286671: Replace use of RandomAccessFile with FileChannel
Marked as reviewed by alanb (Reviewer).
test/jdk/java/nio/channels/FileChannel/LargeMapTest.java line 38:
> 36: * @enablePreview
> 37: * @bug 8286637
> 38: * @requires os.family == "windows"
What was the conclusion on whether this test should run everywhere?
test/jdk/java/nio/channels/FileChannel/LargeMapTest.java line 56:
> 54: Path p = Path.of(FILE);
> 55: p.toFile().deleteOnExit();
> 56: try (FileChannel fc = FileChannel.open(p, CREATE, WRITE);) {
spurious semicolon has snuck in here
-------------
PR: https://git.openjdk.java.net/jdk/pull/8686
More information about the nio-dev
mailing list