RFR: 8293067: (fs) Implement WatchService using system library (macOS) [v7]
Maxim Kartashev
mkartashev at openjdk.org
Tue Nov 1 11:09:18 UTC 2022
On Sun, 9 Oct 2022 14:05:38 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> Maxim Kartashev has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Dropped __unused attributes from used parameters
>
> It's a real shame that it requires use of a CFRunLoop and callbacks but if that is the only facility that it provides then I suppose we have to use it. I see the discussion about using a socketpair but I don't think that is sensible thing to do here. The socketpair that is used elsewhere is for wakeup only, similar to what we do in the Selector implementations. So I think we should move forward with the current approach but probably will need a few rounds of cleanup.
@AlanBateman Are there any outstanding issues that prevents this from being merged, apart from maybe the implementation of the [CSR](https://bugs.openjdk.org/browse/JDK-8296164)? I believe I addressed all the concerns raised in your comment from Sep, 11, but if more have been found since then, please do let me know.
-------------
PR: https://git.openjdk.org/jdk/pull/10140
More information about the nio-dev
mailing list