RFR: 8293067: (fs) Implement WatchService using system library (macOS) [v9]

[Michael Hall]

> On Nov 7, 2022, at 8:47 PM, Brian Burkhalter <brian.burkhalter at oracle.com> wrote:
> 
> 
>> On Nov 4, 2022, at 5:51 AM, Michael Hall <mik3hall at gmail.com <mailto:mik3hall at gmail.com>> wrote:
>> 
>> 
>> 
>>>> 
>>>> 
>>>> 
>>>> I had a thought for some code to try this on but seem to get a number of build errors now.
>>>> 
>>>> http://mikehall.pairserver.com/errors10140.txt <http://mikehall.pairserver.com/errors10140.txt> <http://mikehall.pairserver.com/errors10140.txt <http://mikehall.pairserver.com/errors10140.txt>>
>>>> 
>>>> Using the GitHub Desktop app to change to pr/10140
>>>> 
>>>> -------------- next part -------------- An HTML attachment was scrubbed... URL: <https://mail.openjdk.org/pipermail/nio-dev/attachments/20221102/d5ad452a/attachment.htm <https://mail.openjdk.org/pipermail/nio-dev/attachments/20221102/d5ad452a/attachment.htm>>
>>> 
>>> You are using xcode 14 with sdk for macos Ventura hence having issues. that's orthogonal to this PR.
>>> 
>>> -------------
>>> 
>>> PR: https://git.openjdk.org/jdk/pull/10140 <https://git.openjdk.org/jdk/pull/10140>
>> What was suggested as the error here - isn’t. For me this doesn’t build with the errors given in the link. 
> 
> No problem for me building with
> 
> * Toolchain:      clang (clang/LLVM from Xcode 12.4)
> 
> on macOS Monterey.

I’m also Monterey. Some of the errors were javac ones as well which should eliminate Xcode so I’m not sure what is going on. I am now 14.1 Xcode since it basically made me upgrade the last time I tried to launch but wasn’t when I got the errors. Might look at it some more. Pretty new to building these so it could very well be something I messed up. I had got something about a git merge conflict that seemed to disappear on it’s own.
For now I have just been coding up a WatchService using the polling current one.  

*** Javac error

/Users/mjh/Documents/GitHub/jdk/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/TagletWriter.java:38: error: cannot find symbol
import com.sun.source.doctree.SpecTree;
                             ^
  symbol:   class SpecTree
  location: package com.sun.source.doctree
   ... (rest of output omitted)

*** A lot of sprintf deprecated related errors, also show I was MacOSX13.0.sdk at the time.

* For target hotspot_variant-server_tools_adlc_objs_adlparse.o:
/Users/mjh/Documents/GitHub/jdk/src/hotspot/share/adlc/adlparse.cpp:215:11: error: 'sprintf' is deprecated: This function is provided for compatibility reasons only.  Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead. [-Werror,-Wdeprecated-declarations]
          sprintf(buf, "%s_%d", instr->_ident, match_rules_cnt++);
          ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.0.sdk/usr/include/stdio.h:188:1: note: 'sprintf' has been explicitly marked deprecated here
__deprecated_msg("This function is provided for compatibility reasons only.  Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead.")
^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.0.sdk/usr/include/sys/cdefs.h:215:48: note: expanded from macro '__deprecated_msg'
        #define __deprecated_msg(_msg) __attribute__((__deprecated__(_msg)))

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/nio-dev/attachments/20221108/604a1435/attachment-0001.htm>