RFR: 8293696: java/nio/channels/DatagramChannel/SelectWhenRefused.java fails with "Unexpected wakeup" [v9]

[Darragh Clarke]

On Tue, 8 Nov 2022 14:12:52 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Darragh Clarke has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   further cleanup
>
> test/jdk/java/nio/channels/DatagramChannel/SelectWhenRefused.java line 38:
> 
>> 36: import java.util.Set;
>> 37: 
>> 38: import static jdk.test.lib.Asserts.assertNotEquals;
> 
> Ah! Darn. I wonder if we should convert the test to testng or junit instead, just for the purpose of using junit/testng assertions. It would avoid the need of linking to /test/lib too. Just some idle thought.
> The other day Pavel and I were wondering if that Asserts class should be retired - given that we have them available in testng/junit now...

I wouldn't be against changing it, At a glance using Junit is only around 10 lines of changes, though I'm not sure if theres any additional patterns I should follow in swapping it to junit beyond using `@Test` instead of a main method?

-------------

PR: https://git.openjdk.org/jdk/pull/10851