RFR: 8249693: java/nio/channels/FileChannel/FileExtensionAndMap.java uses @ignore w/o bug id

[Matthew Donovan]

On Mon, 7 Nov 2022 20:05:24 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Added a check that source and destination volumes have enough space to run the test.
>> 
>> This test will no longer be ignored.
>
> test/jdk/java/nio/channels/FileChannel/FileExtensionAndMap.java line 134:
> 
>> 132:         long totalDiskSpaceNeeded = FILESIZE * PARALLELISM;
>> 133: 
>> 134:         if (Files.getFileStore(tmpDir).name().equals(Files.getFileStore(destinationPath).name())) {
> 
> I think you should be using FileStore::equals rather than equality of the name here.

Done

> test/jdk/java/nio/channels/FileChannel/FileExtensionAndMap.java line 139:
> 
>> 137:             if (usableDiskSpace < totalDiskSpaceNeeded) {
>> 138:                 throw new SkippedException("Insufficient disk space on " + TMPDIR + ". Test requires: " + totalDiskSpaceNeeded + ". Available on disk: " + usableDiskSpace);
>> 139:             }
> 
> Can you break. these overfly long lines so that future side-by-side diffs are possible?

Sure, done.

-------------

PR: https://git.openjdk.org/jdk/pull/11028