RFR: 8293067: (fs) Implement WatchService using system library (macOS) [v7]

Maxim Kartashev mkartashev at openjdk.org
Mon Oct 10 10:33:43 UTC 2022


On Sun, 9 Oct 2022 13:50:53 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Maxim Kartashev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Dropped __unused attributes from used parameters
>
> src/java.base/share/native/libnio/nio_util.c line 37:
> 
>> 35: {
>> 36:     JNIEnv *env;
>> 37:     jvm = vm;
> 
> Would it be possible for MacOSXWatchService to use GetJavaVM is its initializer so that the changes to nio_util.* can be reverted?

Of course. Fixed.

-------------

PR: https://git.openjdk.org/jdk/pull/10140


More information about the nio-dev mailing list