RFR: 8293067: (fs) Implement WatchService using system library (macOS) [v8]

Maxim Kartashev mkartashev at openjdk.org
Tue Oct 11 12:15:27 UTC 2022


On Tue, 11 Oct 2022 08:07:51 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

>> Maxim Kartashev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Don't use JavaVM exported from nio_util.c
>
> src/java.base/macosx/classes/sun/nio/fs/MacOSXWatchService.java line 348:
> 
>> 346: 
>> 347:             synchronized (eventStreamRefLock) {
>> 348:                 final int kFSEventStreamCreateFlagWatchRoot  = 0x00000004;
> 
> Suggestion:
> 
>                 final int kFSEventStreamCreateFlagWatchRoot = 0x00000004;

Thanks! I'll wait for more formatting-related input from @AlanBateman and others and then do all the changes in bulk.

-------------

PR: https://git.openjdk.org/jdk/pull/10140


More information about the nio-dev mailing list