RFR: 8293067: (fs) Implement WatchService using system library (macOS) [v8]

[Brian Burkhalter]

On Wed, 19 Oct 2022 05:54:56 GMT, Maxim Kartashev <mkartashev at openjdk.org> wrote:

>> src/java.base/macosx/classes/sun/nio/fs/BsdFileSystem.java line 55:
>> 
>>> 53:         throws IOException
>>> 54:     {
>>> 55:         return new MacOSXWatchService();
>> 
>> Is it still intended that there be a system property to enable `MacOSXWatchService` which would be off by default?
>
> There was such a suggestion (not sure about "off by default", though). I guess this should go through CSR review, in which case I'm going to need some guidance.

If you file a CSR then I can help with editing.

>> src/java.base/macosx/classes/sun/nio/fs/MacOSXWatchService.java line 379:
>> 
>>> 377: 
>>> 378:         private Path toRelativePath(final String absPath) {
>>> 379:             return   (absPath.length() > realRootPathLength)
>> 
>> Nit: Are there several spaces after `return`?
>
> Yes, to align the beginning of the returned expression with its continuations on the subsequent two lines.

OK

-------------

PR: https://git.openjdk.org/jdk/pull/10140