RFR: 8293067: (fs) Implement WatchService using system library (macOS) [v8]
Brian Burkhalter
bpb at openjdk.org
Wed Oct 19 16:59:25 UTC 2022
On Wed, 19 Oct 2022 06:23:50 GMT, Maxim Kartashev <mkartashev at openjdk.org> wrote:
>> I'll change the spelling of all but `kFSEventStreamEventFlagRootChanged`, which I'd rather keep as is. The constant being spelled exactly the same as in the corresponding C header file makes it easier to check its correctness (https://developer.apple.com/documentation/coreservices/1455361-fseventstreameventflags/kfseventstreameventflagrootchanged?language=objc).
>> As for moving it to `UnixConstants`, I'm also not so sure as it is hardly a "Unix" constant, more like a macOS constant.
>
> How about I make `kFSEventStreamEventFlagRootChanged` into a local variable? It's only used in one place and doesn't have to be a static field really.
Sounds good.
-------------
PR: https://git.openjdk.org/jdk/pull/10140
More information about the nio-dev
mailing list