RFR: 8295798: (ch) Test java/nio/channels/Channels/ReadXBytes.java is very slow on Windows [v2]

Brian Burkhalter bpb at openjdk.org
Mon Oct 24 16:40:52 UTC 2022


On Mon, 24 Oct 2022 15:27:47 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

>> Please review this PR that reduces the number of bytes written by ReadXBytes test on machines supporting sparse files.
>> 
>> Before this change the `createFileWithRandomContent` function would usually write either the last byte only, or the entire file (`long p` was usually set to length - 1). Now the function only writes the first and the last 32kB, and the remaining bytes are initialized in platform-defined manner.
>> 
>> Before this change the test took between 1-10 minutes to complete on our Windows CI machines.
>> After this change the test finishes in less than 1 minute.
>
> Daniel Jeliński has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update copyright

Looks good, thanks.

-------------

Marked as reviewed by bpb (Reviewer).

PR: https://git.openjdk.org/jdk/pull/10834


More information about the nio-dev mailing list