RFR: 8289689: (fs) Re-examine the need for normalization to Unicode Normalization Format D (macOS) [v2]

[Brian Burkhalter]

On Fri, 28 Oct 2022 15:42:54 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8289689: Use GetPropertyAction; rename property
>
> src/java.base/macosx/classes/sun/nio/fs/MacOSXFileSystem.java line 42:
> 
>> 40: 
>> 41:     private static final boolean ENCODE_FILE_NAMES =
>> 42:         Boolean.getBoolean(PROPERTY_ENABLE_FILE_NAME_ENCODING);
> 
> APFS is the default since macOS 10.13 but I agree, it's safer to have a system property for a few releases in case anything is relying on this.
> 
> I assume you'll need to use GetPropertyAction.privilegedGetProperty so that it works when there is a security manager set.
> 
> As regards the property name then it will need to be jdk.something because it's JDK specific rather than a standard property. Maybe something like -Djdk.nio.path.useNormalizationFormD ?

Fixed in ab2e42dbfc47ffe9026e769ef5d9329ee9098452.

-------------

PR: https://git.openjdk.org/jdk/pull/10885