RFR: 8289689: (fs) Re-examine the need for normalization to Unicode Normalization Format D (macOS) [v2]
Brian Burkhalter
bpb at openjdk.org
Mon Oct 31 16:37:39 UTC 2022
On Sat, 29 Oct 2022 11:36:27 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
>> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>>
>> 8289689: Use GetPropertyAction; rename property
>
> test/jdk/java/nio/file/Path/MacPathTest.java line 51:
>
>> 49: ProcessBuilder pb;
>> 50: if (ENABLE_FILE_NAME_ENCODING) {
>> 51: String option = ENABLE_FILE_NAME_ENCODING ?
>
> Hello Brian, it appears that the additional ternary check here is unecessary since the enclosing `if (ENABLE_FILE_NAME_ENCODING)` already implies `ENABLE_FILE_NAME_ENCODING` is `true`.
Indeed that is lame. Thanks for catching it. Fixed in b420d2cea162ef7a3abde0522d687a290fe154f2.
-------------
PR: https://git.openjdk.org/jdk/pull/10885
More information about the nio-dev
mailing list