RFR: 8293121: (fs) Refactor UnixFileSystem copying into generic Unix, Linux, and BSD implementations [v3]

Alan Bateman alanb at openjdk.org
Thu Sep 1 08:00:12 UTC 2022


On Wed, 31 Aug 2022 16:21:25 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> Refactor `UnixFileSystem` and related classes to move implementations specific to Linux and BSD (macOS) into OS-specific classes and native code. Generic Unix implementations remain in existing `Unix*` files.
>
> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8293121: Forgot to move UnixCopyFile.c to UnixFileSystem.c

src/java.base/linux/native/libnio/fs/LinuxNativeDispatcher.c line 151:

> 149:     jint fd, jlong offset, jlong len, jint advice)
> 150: {
> 151:     return posix_fadvise((int)fd, (off_t)offset, (off_t)len, (int)advice);

I assume this should posix_fadvise64 as you'll need a off64_t on 32-bit systems.

-------------

PR: https://git.openjdk.org/jdk/pull/10093


More information about the nio-dev mailing list