RFR: 8293122: (fs) Use file cloning in macOS version of Files::copy method [v2]

[Brian Burkhalter]

On Fri, 9 Sep 2022 07:25:57 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8293122: Revert BsdFileStore; move volume capability check to BsdNativeDispatcher
>
> src/java.base/macosx/classes/sun/nio/fs/BsdFileSystem.java line 149:
> 
>> 147:                 } catch (UnixException x) {
>> 148:                     if (flags.failIfUnableToCopyPosix)
>> 149:                         x.rethrowAsIOException(target);
> 
> Can you compare this to the Unix implementation as I thought there was a best attempt to unlink when throwing an exception?

You are correct: thanks for catching my gaffe. Fixed in f51cd186fe624d03ce7c6a4f49140998e2d48322.

-------------

PR: https://git.openjdk.org/jdk/pull/10188