RFR: 8293067: (fs) Implement WatchService using system library (macOS) [v3]

Maxim Kartashev mkartashev at openjdk.org
Wed Sep 14 06:06:40 UTC 2022


On Tue, 13 Sep 2022 17:49:19 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

> I reran the java/nio/file/WatchService tests with the current code and there were no failures this time. I wonder whether this might be due to the change from CFRunLoopThread to InnocuousThread?

Thanks! Let's hope it stays this way. 

BTW, my initial version did have a thread cleanup problem that was caught by other tests. That was because I assumed the run loop would exit as soon as all input sources are pulled from it; that assumption proved to be false, so now there's `MacOSXWatchService.runLoopStop()`.

-------------

PR: https://git.openjdk.org/jdk/pull/10140


More information about the nio-dev mailing list