RFR: 8293331: Refactor FileDispatcherImpl into operating system-specific components [v3]

Brian Burkhalter bpb at openjdk.org
Tue Sep 20 16:47:46 UTC 2022


On Mon, 19 Sep 2022 18:51:59 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> I took a first pass over the latest update and it looks quite good. I assume the issue and description should be changed now as this is about refactoring of FileDispatcherImpl rather than FileChannelImpl.
>> 
>> Could FileChannelImpl.nd be a static field, there doesn't seen to be any reason to create one per FileChannel now. Also Unmapper shouldn't need its own now either.
>> 
>> Can the static initialiser that calls IOUtil.load be removed from FileChannelImpl? The library loading is pushed down to FileDispatcherImpl now so I assume it is not needed.
>
>> Could FileChannelImpl.nd be a static field, there doesn't seen to be any reason to create one per FileChannel now. Also Unmapper shouldn't need its own now either.
>> 
>> Can the static initialiser that calls IOUtil.load be removed from FileChannelImpl? The library loading is pushed down to FileDispatcherImpl now so I assume it is not needed.
> 
> Above all fixed in c6e271eb0d23f846d4c5ef55c3cb32ba2f7d896d.

> I am happy to test this on AIX @bplb & @AlanBateman. I will update this message when it completes.
> 
> Testing in progress

Thank you!

-------------

PR: https://git.openjdk.org/jdk/pull/10154


More information about the nio-dev mailing list