RFR: 8293331: Refactor FileDispatcherImpl into operating system-specific components [v5]
Brian Burkhalter
bpb at openjdk.org
Wed Sep 21 16:00:18 UTC 2022
On Wed, 21 Sep 2022 00:45:52 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:
>> The overall refactoring looks okay. Most of the change is code moving to another file so it's hard to see if there are any changes and it's hard to see if the list of include files is accurate. Everything I checked seemed okay and unchanged.
>
>> [...] it's hard to see if the list of include files is accurate.
>
> Unneeded include files are removed in a2da4deba931fdb67e5bd8b5c34bb562490ace4e. I don't know whether the absence of those removed in `UnixFileDispactherImpl` will cause problems on AIX (@backwaterred please test the build again, thanks).
> Looking good @bplb. The jdk/nio tests are all passing.
Thank you, @backwaterred, for the assist.
-------------
PR: https://git.openjdk.org/jdk/pull/10154
More information about the nio-dev
mailing list