RFR: 8293331: Refactor FileDispatcherImpl into operating system-specific components [v8]

Brian Burkhalter bpb at openjdk.org
Thu Sep 22 16:03:03 UTC 2022


On Thu, 22 Sep 2022 06:00:38 GMT, Vyom Tewari <vtewari at openjdk.org> wrote:

>> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8293331: Add missing init() call in UnixFileDispatcherImpl static initializer
>
> src/java.base/linux/classes/sun/nio/ch/FileDispatcherImpl.java line 51:
> 
>> 49:     // -- Native methods --
>> 50: 
>> 51:     static native long transferTo0(FileDescriptor src, long position,
> 
> can we make these native methods(transferTo0, transferFrom0 etc) to private access specifier,  these methods are not called from outside ?.

This comment applies to a lot of code. See `UnixFileDispatcherImpl` for example. I prefer not to change it at this time.

-------------

PR: https://git.openjdk.org/jdk/pull/10154


More information about the nio-dev mailing list