Integrated: 8294193: Files.createDirectories throws FileAlreadyExistsException for a symbolic link whose target is an existing directory

Jaikiran Pai jpai at openjdk.org
Mon Sep 26 05:20:18 UTC 2022


On Thu, 22 Sep 2022 06:34:53 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review of this change which proposes to fix the issue noted in https://bugs.openjdk.org/browse/JDK-8294193?
> 
> As discussed in a related PR https://github.com/openjdk/jdk/pull/10266#issuecomment-1246800456, this is a genuine bug in the `java.nio.file.Files.createDirectories` implementation. The commit in this PR fixes that by making sure that links are followed when checking if a `Path` is a directory during the creation of directories in the `createDirectories` implementation. The `private` method which is changed in this PR is only used in the `Files.createDirectories` and no other place, so this change should not impact any other code. Additionally a new test has been added to reproduce the issue and verify the fix.
> tier1, tier2 and tier3 tests passed with this change.

This pull request has now been integrated.

Changeset: 169a5d48
Author:    Jaikiran Pai <jpai at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/169a5d48afbc6627f36a768c17c2a5e56219d9c7
Stats:     161 lines in 3 files changed: 124 ins; 34 del; 3 mod

8294193: Files.createDirectories throws FileAlreadyExistsException for a symbolic link whose target is an existing directory

Reviewed-by: alanb

-------------

PR: https://git.openjdk.org/jdk/pull/10383


More information about the nio-dev mailing list