RFR: 8293067: (fs) Implement WatchService using system library (macOS) [v5]

Maxim Kartashev mkartashev at openjdk.org
Tue Sep 27 07:26:04 UTC 2022


On Mon, 26 Sep 2022 21:04:31 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

>> Maxim Kartashev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains ten commits:
>> 
>>  - Merge master
>>  - Minor changes based on review comments
>>  - Removed the change unnecessary without recursive watch
>>  - Removed support for recursive watch
>>  - Reformatted native code and removed jlong and pointer casts
>>  - Removed the dependency on provider(Path)
>>  - More robust way of obtaining run loop reference
>>  - CFRunLoopThread to use InnocuousThread
>>  - 8293067: (fs) Implement WatchService using system library (macOS)
>
> src/java.base/macosx/classes/sun/nio/fs/MacOSXWatchService.java line 313:
> 
>> 311:         private static final long kFSEventStreamEventFlagRootChanged     = 0x00000020;
>> 312: 
>> 313:         private final static Path relativeRootPath = theFS.getPath("");
> 
> let's use blessed modifiers order: `private static final`

Sure! Fixed this one.

-------------

PR: https://git.openjdk.org/jdk/pull/10140


More information about the nio-dev mailing list