RFR: 8294375: test/jdk/java/nio/channels/vthread/BlockingChannelOps.java is slow [v2]
Alan Bateman
alanb at openjdk.org
Wed Sep 28 10:01:18 UTC 2022
On Wed, 28 Sep 2022 09:45:39 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
> Now that these tests complete fast, do you think we should now remove all the `/timeout=300` from each of the test definitions?
I'll have to check. The reason for /timeout on some of these tests is because most of the testing has been with debug builds rather than release builds.
> test/jdk/java/net/vthread/BlockingSocketOps.java line 722:
>
>> 720: /**
>> 721: * Runs the given task asynchronously after the current virtual thread has
>> 722: * parked, or after a max wait time, whichever is first.
>
> Does this comment need an update to match the current implementation? From what I can see in the current implementation of `runAfterParkedAsync`, in this PR, it doesn't have a "max wait time" construct before triggering the task.
Well spotted, that comment is out of date now.
-------------
PR: https://git.openjdk.org/jdk/pull/10427
More information about the nio-dev
mailing list