RFR: 8304911: Use OperatingSystem enum in some modules

Roger Riggs rriggs at openjdk.org
Wed Apr 5 14:22:29 UTC 2023


On Wed, 5 Apr 2023 08:37:27 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> With the addition of `jdk.internal.util.OperatingSystem` references to the system property `os.name` can be replaced.
>> This PR exports jdk.internal.util to:
>>  - java.prefs,
>>  - java.security.jgss,
>>  - java.smartcardio,
>>  - jdk.charsets,
>>  - jdk.net,
>>  - jdk.zipfs
>
> src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipFileSystem.java line 2882:
> 
>> 2880:                     elenNTFS = 36;           // total 36 bytes
>> 2881:                 } else {                     // Extended Timestamp otherwise
>> 2882:                     elenEXTT = 9;            // only mtime in cen
> 
> It might be better to drop ZipFileSystem from this patch and instead create a bug to re-examine this code. I would have expected it use NFTS when the timestamp is beyond the range of an extended timestamp. It shouldn't be looking at the current OS name.

Created [JDK-8305662](https://bugs.openjdk.org/browse/JDK-8305662) to track refactoring.
Will revert.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13335#discussion_r1158587949


More information about the nio-dev mailing list