RFR: 8305596: (fc) Two java/nio/channels tests fail after JDK-8303260 [v2]

Brian Burkhalter bpb at openjdk.org
Wed Apr 5 15:03:17 UTC 2023


On Wed, 5 Apr 2023 08:09:41 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8305596: Fix size check
>
> test/jdk/java/nio/channels/FileChannel/Transfer.java line 101:
> 
>> 99:             throw new RuntimeException("Wrote too many bytes");
>> 100: 
>> 101:         if (sinkChannel.size() != 1010)
> 
> I assume this should be `1000 + bytesWritten` rather than 1010.

Yes.

There are other places in here where it is not accounted for that transferX can return less than the count specified.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13342#discussion_r1158643107


More information about the nio-dev mailing list